Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to Safari Proxy bug #1

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix to Safari Proxy bug #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d8b0df
Fix to Safari Proxy bug
bornajazvo Oct 23, 2023
05e525c
🔖 v2.0.0-reedsy.1.0.2
bornajazvo Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "floating-vue-monorepo",
"packageManager": "pnpm@8.6.2",
"version": "2.0.0-beta.24",
"version": "2.0.0-reedsy.1.0.2",
"private": true,
"scripts": {
"build": "pnpm -r --filter=\"./packages/*\" run build",
Expand Down
2 changes: 1 addition & 1 deletion packages/floating-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reedsy/floating-vue",
"version": "2.0.0-reedsy.1.0.1",
"version": "2.0.0-reedsy.1.0.2",
"description": "Easy Vue tooltips, dropdowns, menus & popovers using floating-ui",
"author": "Guillaume Chau <guillaume.b.chau@gmail.com>",
"scripts": {
Expand Down
6 changes: 3 additions & 3 deletions packages/floating-vue/src/components/Popper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
const shownPoppers = []
let hidingPopper = null

const shownPoppersByTheme: Record<string, any[]> = {}

Check warning on line 24 in packages/floating-vue/src/components/Popper.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected any. Specify a different type
function getShownPoppersByTheme (theme: string) {
let list = shownPoppersByTheme[theme]
if (!list) {
Expand All @@ -30,7 +30,7 @@
return list
}

let Element: any = function () {}

Check warning on line 33 in packages/floating-vue/src/components/Popper.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected any. Specify a different type
if (typeof window !== 'undefined') {
Element = window.Element
}
Expand Down Expand Up @@ -450,7 +450,7 @@
if (this.$_hideInProgress) return

// Abort if child is shown
if (this.shownChildren.size > 0) {
if (new Set(this.shownChildren).size > 0) {
this.$_pendingHide = true
return
}
Expand Down Expand Up @@ -665,7 +665,7 @@
})
},

$_scheduleShow (event = null, skipDelay = false) {

Check warning on line 668 in packages/floating-vue/src/components/Popper.ts

View workflow job for this annotation

GitHub Actions / build 

'event' is assigned a value but never used
this.$_updateParentShownChildren(true)
this.$_hideInProgress = false
clearTimeout(this.$_scheduleTimer)
Expand All @@ -683,8 +683,8 @@
}
},

$_scheduleHide (event = null, skipDelay = false) {

Check warning on line 686 in packages/floating-vue/src/components/Popper.ts

View workflow job for this annotation

GitHub Actions / build 

'event' is assigned a value but never used
if (this.shownChildren.size > 0) {
if (new Set(this.shownChildren).size > 0) {
this.$_pendingHide = true
return
}
Expand Down Expand Up @@ -788,7 +788,7 @@
},

async $_applyHide (skipTransition = false) {
if (this.shownChildren.size > 0) {
if (new Set(this.shownChildren).size > 0) {
this.$_pendingHide = true
this.$_hideInProgress = false
return
Expand Down Expand Up @@ -906,7 +906,7 @@
this.$_registerTriggerListeners([this.$_popperNode], HIDE_EVENT_MAP, this.popperTriggers, this.popperHideTriggers, handleHide)
},

$_registerEventListeners (targetNodes: any[], eventType: string, handler: (event: Event) => void) {

Check warning on line 909 in packages/floating-vue/src/components/Popper.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected any. Specify a different type
this.$_events.push({ targetNodes, eventType, handler })
targetNodes.forEach(node => node.addEventListener(eventType, handler, supportsPassive
? {
Expand All @@ -915,7 +915,7 @@
: undefined))
},

$_registerTriggerListeners (targetNodes: any[], eventMap: Record<string, string>, commonTriggers, customTrigger, handler: (event: Event) => void) {

Check warning on line 918 in packages/floating-vue/src/components/Popper.ts

View workflow job for this annotation

GitHub Actions / build 

Unexpected any. Specify a different type
let triggers = commonTriggers

if (customTrigger != null) {
Expand Down
Loading