Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes occasional Safari bug that causes a break in Vue if using Set. There doesn't seem to be a reliable way to recreate it, closest I got was opening and closing dev tools while the app is loading but the timing is very strict and inconsistent.
This setup:
results in:
target
,key
, andreceiver
this
target
Seems like a Safari issue that on
Reflect.get
it turns thereceiver
Proxy into an object. Then it fails astarget
gets redefined assuming it’s a Proxy, and this returnsundefined
which errors when passed intoReflect.get
.This is the least disruptive fix to the bug, as we no longer rely on the Vue Proxy when checking size of
Set
.