Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version to 1.2.0dev #22

Merged
merged 2 commits into from
Nov 25, 2024
Merged

bump version to 1.2.0dev #22

merged 2 commits into from
Nov 25, 2024

Conversation

famosab
Copy link
Collaborator

@famosab famosab commented Nov 25, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

d4straub
d4straub approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that you have a .nf-core.yml that was not updated for 1.1.0 and also not in this PR to 1.2.0dev. Sorry, I assumed that file isnt present in non-nf-core pipelines and I didnt check. I approve anyway.

@famosab
Copy link
Collaborator Author

famosab commented Nov 25, 2024

I'll change the file here then. I always assumed nf-core pipelines bump-version would take care of everything...

@famosab famosab merged commit b340c7e into qbic-pipelines:dev Nov 25, 2024
5 checks passed
@famosab famosab deleted the bump-dev branch November 25, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@famosab @d4straub