Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add evidence filters #57

Merged
merged 16 commits into from
Oct 10, 2024
Merged

feat: add evidence filters #57

merged 16 commits into from
Oct 10, 2024

Conversation

HomoPolyethylen
Copy link
Contributor

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.rst is updated

Description of changes

Technical details

Additional context

@HomoPolyethylen HomoPolyethylen marked this pull request as ready for review October 9, 2024 15:12
@HomoPolyethylen HomoPolyethylen self-assigned this Oct 9, 2024
mapo9
mapo9 requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just 2 minor things

CHANGELOG.rst Outdated Show resolved Hide resolved
querynator/__main__.py Show resolved Hide resolved
mapo9
mapo9 reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
The thesis is looking more and more Goldilock!

@HomoPolyethylen
Copy link
Contributor Author

lgtm! The thesis is looking more and more Goldilock!

dann brauche ich nur noch grünes Licht ;)

@HomoPolyethylen HomoPolyethylen merged commit 8ab9990 into qbic-pipelines:dev Oct 10, 2024
9 checks passed
HomoPolyethylen added a commit that referenced this pull request Oct 10, 2024
@HomoPolyethylen
r0.6.0
309e365 
feat: add evidence filters (#57)
Merge pull request #58 from qbic-pipelines/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapo9 mapo9 mapo9 approved these changes

Assignees

@HomoPolyethylen HomoPolyethylen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HomoPolyethylen @mapo9