Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

civic+cgi evidence bug fixes & example data update #53

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

HomoPolyethylen
Copy link
Contributor

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.rst is updated

Description of changes

Technical details

Additional context

HomoPolyethylen and others added 5 commits September 6, 2024 14:24
closes qbic-pipelines#52

Squashed commit of the following:

commit 0337fda
Author: Niclas Grote <casimir.grote@gmail.com>
Date:   Fri Sep 6 12:43:29 2024 +0200

    update changelog

commit 00b4dda
Author: Niclas Grote <casimir.grote@gmail.com>
Date:   Thu Sep 5 18:00:23 2024 +0200

    fix: replace evidence-level separator to distinguish from variant-level separator

commit 8345c59
Author: Niclas Grote <casimir.grote@gmail.com>
Date:   Thu Sep 5 17:56:10 2024 +0200

    fix: list init bug leading to inconsitent number of fields
Merge pull request #3 from HomoPolyethylen/51_CGI-filter-evidences-by-cancer-type
@HomoPolyethylen
Copy link
Contributor Author

If prefered, I could split this PR into 2-3 seperate PRs (bug51, bug52, release)

@HomoPolyethylen HomoPolyethylen marked this pull request as ready for review September 9, 2024 12:49
Copy link

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Just two minor comments

@HomoPolyethylen HomoPolyethylen merged commit 21b8e58 into qbic-pipelines:dev Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants