Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed query-api-civic --cancer bug #33 #35

Merged
merged 19 commits into from
Jul 3, 2024
Merged

fixed query-api-civic --cancer bug #33 #35

merged 19 commits into from
Jul 3, 2024

Conversation

mapo9
Copy link
Collaborator

@mapo9 mapo9 commented Jul 3, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.rst is updated

Description of changes

Technical details

Additional context

HomoPolyethylen and others added 15 commits July 2, 2024 16:06
@HomoPolyethylen
refactored and fixed #33
7ea9ff1
@HomoPolyethylen
refactored & added tests for civic and cgi queries
ecec389
@HomoPolyethylen
lint
92b60e4
@HomoPolyethylen
exclude .obo files
1a1bce7
@HomoPolyethylen
lint
74ba659
@HomoPolyethylen
try to fix CI pytest fail by pinning numpy version
ba5584e
@HomoPolyethylen
Revert "try to fix CI pytest fail by pinning numpy version"
28fead5 
This reverts commit ba5584e.
@HomoPolyethylen
try debugging CI
0822033
@HomoPolyethylen
don't ignore tsv files, include relevant cgi output files for tests
588138b
@HomoPolyethylen
done debugging CI
917c899 
This reverts commit 0822033.
@HomoPolyethylen
use same requirements for testing as deploymnet
bcff698
@HomoPolyethylen
include relevant cgi output files for tests
6cee396 
This reverts commit 588138b.
@HomoPolyethylen
now for real: add relevant cgi output files
1182bbd
@HomoPolyethylen
refactored & added more cgi tests
ae137b1
@mapo9
Merge pull request #34 from HomoPolyethylen/HomoPolyethylen/issue33
e087d53 
Homo polyethylen/issue33
@HomoPolyethylen HomoPolyethylen changed the title Dev fix query-api-civic --cancer bug #33 Jul 3, 2024
@HomoPolyethylen HomoPolyethylen changed the title fix query-api-civic --cancer bug #33 fixed query-api-civic --cancer bug #33 Jul 3, 2024
HomoPolyethylen
HomoPolyethylen approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@HomoPolyethylen HomoPolyethylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoever did this is a michelangelo on the keyboard...

@HomoPolyethylen HomoPolyethylen merged commit 392f9f4 into master Jul 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HomoPolyethylen HomoPolyethylen HomoPolyethylen approved these changes

@famosab famosab Awaiting requested review from famosab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapo9 @HomoPolyethylen