Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homo polyethylen/issue33 #34

Merged
merged 14 commits into from
Jul 3, 2024

Conversation

HomoPolyethylen
Copy link
Contributor

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.rst is updated

Description of changes

fixed a bug, which left querynator query-api-civic unusable. Also added tests, so that such a thing does not happen so easily anymore.
closes #33

Technical details

Additional context

@HomoPolyethylen HomoPolyethylen self-assigned this Jul 2, 2024
@HomoPolyethylen HomoPolyethylen marked this pull request as ready for review July 3, 2024 10:09
@HomoPolyethylen HomoPolyethylen linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, sucks to have bad reviewers

@mapo9 mapo9 merged commit e087d53 into qbic-pipelines:dev Jul 3, 2024
9 checks passed
@HomoPolyethylen HomoPolyethylen deleted the HomoPolyethylen/issue33 branch July 3, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query-api-civic: unknown param 'cancer'
2 participants