-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cancer type in CIViC results #28
use cancer type in CIViC results #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell it looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great so far!
I only have 2 minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you check why the tests are failing?
New changes look good to me. Pytest seems to run into some kind of numpy error: StackOverflow has a solution I think: https://stackoverflow.com/questions/78634235/numpy-dtype-size-changed-may-indicate-binary-incompatibility-expected-96-from |
You'll need to fix the version of numpy to 1.26.4 for example (probably in the requirements file). Line 10 in 2f24ccd
|
PR Checklist
docs
is updatedCHANGELOG.rst
is updatedDescription of changes
-d
/--cancer-doid
)Technical details
querynator
filters evidence items in results:Additional context
CGI and CIViC use different ontologies (CGI: OncoTree, CIViC: Disease-Ontology. Right now they need to be specified separately, passing the burden to map ontologies to the user.
This should be attended to in the future. Let user specify one cancer type, querynator maps to OncoTree / DO, queries, ...