Fix type detection issues #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, pshjt.
This pull request should correct a couple of small issues with the mod type detection. In particular, some of the Thief-only resource directory names are missing, with the most important of these being "books". More significantly, the resource file detection does not currently work for script files due to a single missing comma, which causes the final two members of the list to be concatenated instead. This can cause some resource mods to be unrecognized despite being valid.
On another note, I see that there is now also a "Script" mod type, though it will seemingly only be applied for SCP due to it supplying the requisite "scriptdata" directory. I did not include this change since this may be intentional, but it would probably make sense to have OSMs and Squirrel scripts be detected using this category rather than as generic resources.