-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented 2-epoch demographic model for Vaquita #1526
Conversation
Awesome! I've tried bumping the cache number to get the tests to run?!?! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - one minor wording fix!
Closes #1508. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 125 126 +1
Lines 4217 4228 +11
Branches 588 588
=======================================
+ Hits 4211 4222 +11
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
Co-authored-by: Peter Ralph <petrel.harp@gmail.com>
These tests run fine locally for me; I will merge this without CI passing, pending #1529 . |
Can you open the QC issue, @igronau ? |
I implemented the 2-epoch demographic model from Robinson et al. (2022), which is what we plan on using for the simulations in the selection paper (for DFE inference). See #1508