Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vaquita #1508

Closed
petrelharp opened this issue Aug 15, 2023 · 10 comments
Closed

add vaquita #1508

petrelharp opened this issue Aug 15, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@petrelharp
Copy link
Contributor

As discussed today, vaquita has a good assembly and various demographic models. It even has a DFE inferred, but @klohmueller says that it doesn't fit significantly better than the human-inferred one added in #1505.

Here's the info: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC9881057/
and see Table S2 for demographic parameter estimates.

@petrelharp petrelharp added the enhancement New feature or request label Aug 15, 2023
@petrelharp
Copy link
Contributor Author

@igronau has volunteered to do this! <3 <3

@igronau
Copy link
Contributor

igronau commented Sep 12, 2023

I'm pretty much done implementing the species. I'm just missing a recombination rate estimate. Couldn't find anything reported for this species or anything closely related. In analyses, studies appear to use 'reasonable values for mammals', or even the human average recombination rate. Will try to sort this out in the next stdpopsim meeting.

@petrelharp
Copy link
Contributor Author

@igronau discussed with @ckyriazis; they decided that the recombination rate is okay.

@igronau
Copy link
Contributor

igronau commented Oct 12, 2023

The species has been added and is now QC'd. This issue can be closed @petrelharp.

@igronau
Copy link
Contributor

igronau commented Oct 12, 2023

I now published a PR with the 2-epoch demographic model. See #1526. @petrelharp - Can you merge?

@igronau
Copy link
Contributor

igronau commented Nov 7, 2023

Species and demographic model have been implemented and QC'd. Now we're waiting for an implementation of the DFE. @ckyriazis - if you implement this, I will QC it :-)

@ckyriazis
Copy link
Contributor

Hi Ilan - sorry for the slow reply. I wasnt actually aware I'd been tasked with the DFE implementation and I'm not sure I'll be able to get to it any time soon. I'm currently trying to finish up some projects before ending my time at UCLA at the end of this month, and will be out all of December before starting a new position in January. Apologies for any miscommunication.

@petrelharp
Copy link
Contributor Author

Wow, congratulations, Chris!

I think maybe your name was mentioned as a possibility; we'll turn up someone else.

@igronau
Copy link
Contributor

igronau commented Nov 15, 2023

Congrats Chris @ckyriazis and good luck with wrapping up in UCLA!

@petrelharp
Copy link
Contributor Author

Closed in #1560 (and other PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants