-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to plasmo v0.6 #7
Open
jalving
wants to merge
15
commits into
plasmo-dev:main
Choose a base branch
from
jalving:jalving/update_to_plasmo-v0.6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI @tso-martin if you want to try this new code out. You will need to update to Plasmo v0.6.4. I need to figure out how to deal with using HiGHS as a sub-solver. It does not seem to play nice with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SchwarzOpt.jl to work with the lastest Plasmo v0.6. The code itself was also refactored to work in a completely decentralized way. There is no shared variable vector that subproblems put and get from. Each subproblem works completely independently and queries the values it needs from its neighbors.
There are some issues now with HiGHS and MadNLP not supporting MOI.Parameter in the right way. HiGHS will error out with an invalid QP solution, and MadNLP currently errors out on what seems to be a bug.