expression: fix wrong calculation order of radians

[gengliqi]

What problem does this PR solve?

Issue Number: close #57671 close #57661

Problem Summary:
See #57671

What changed and how does it work?

radians changes from arg * PI / 180 to arg * (PI / 180) to avoid infinite float and wrong result issues. FYI: https://github.com/mysql/mysql-server/blob/ee079e5ca930ce5ed0643326abadeed8cd41fffc/sql/item_func.h#L1556 MySQL also calculates PI / 180 firstly.
TiKV has already fixed this bug in tikv/tikv#17853.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @gengliqi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

LGTM

[windtalker]

lgtm

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-25 07:43:36.742711468 +0000 UTC m=+449604.362365985: ☑️ agreed by yibin87.
• 2024-11-25 07:47:45.281161643 +0000 UTC m=+449852.900816160: ☑️ agreed by windtalker.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3868%. Comparing base (1015cc0) to head (fa6631d).
Report is 5 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57672        +/-   ##
================================================
+ Coverage   72.8326%   73.3868%   +0.5542%     
================================================
  Files          1676       1677         +1     
  Lines        463747     464320       +573     
================================================
+ Hits         337759     340750      +2991     
+ Misses       105134     102811      -2323     
+ Partials      20854      20759        -95     

Flag	Coverage Δ
integration	43.4393% <50.0000%> (?)
unit	72.2645% <100.0000%> (+0.0315%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	45.5413% <71.4285%> (+0.0944%)	⬆️

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker]
• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gengliqi]

/retest

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/retest

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gengliqi]

/retest

[tiprow]

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #57682.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #57683.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #57684.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #57685.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #57686.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #57687.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57688.