Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Support lower-case test argument passing #5038

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okurz
Copy link
Member

@okurz okurz commented Mar 16, 2023

isotovideo from os-autoinst already automatically transforms lower-case
test parameter command line arguments into upper-case test arguments.
openQA so far only checked the validity of upper-case parameters in a
regex. Instead we can just support supplied lower-ase test parameter
command line arguments as well by just ensuring all arguments are
upper-cased.

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this upper-case any kind of parameter (and not only ones ending up job settings)? Then it would be very wrong.

@okurz
Copy link
Member Author

okurz commented Mar 16, 2023

Wouldn't this upper-case any kind of parameter (and not only ones ending up job settings)? Then it would be very wrong.

Yes, I agree :) I haven't checked that. Tests should tell but apparently my working copy of openQA is outdated.

@Mergifyio rebase

@perlpunk
Copy link
Contributor

Wouldn't this upper-case any kind of parameter (and not only ones ending up job settings)? Then it would be very wrong.

Yeah, and it would also uppercase the value of the setting, e.g. distri=Tumbleweed => DISTRI=TUMBLEWEED

isotovideo from os-autoinst already automatically transforms lower-case
test parameter command line arguments into upper-case test arguments.
openQA so far only checked the validity of upper-case parameters in a
regex. Instead we can just support supplied lower-ase test parameter
command line arguments as well by just ensuring all arguments are
upper-cased.
@okurz
Copy link
Member Author

okurz commented Mar 17, 2023

just rebased, not more

@stale
Copy link

stale bot commented Jun 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants