Allow scheduling and monitoring a product via openqa-cli
#5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
reviewed
Mar 14, 2023
perlpunk
reviewed
Mar 14, 2023
perlpunk
reviewed
Mar 14, 2023
Codecov Report
@@ Coverage Diff @@
## master #5036 +/- ##
========================================
Coverage 98.23% 98.24%
========================================
Files 381 383 +2
Lines 35873 35974 +101
========================================
+ Hits 35241 35342 +101
Misses 632 632
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kalikiana
approved these changes
Mar 16, 2023
kraih
reviewed
Mar 20, 2023
kraih
reviewed
Mar 20, 2023
kraih
requested changes
Mar 20, 2023
kraih
reviewed
Mar 20, 2023
Martchus
added a commit
to Martchus/openQA
that referenced
this pull request
Mar 20, 2023
As mentioned in os-autoinst#5036 (review) this otherwise breaks outputting JSON.
kraih
reviewed
Mar 20, 2023
When configuring exactly one retry, the loop currently does the following (assuming the request fails and should be retried): ``` 1. Request 2. Log "Request failed" and sleep for the configured retry delay ``` So no retry is done despite being logged and sleep being executed. This is identical to zero retries being configured except for 2. but should actually lead to two attempts in total. If more than one retry is configured the problem is the same of course. This change alters the behavior to be (and by the way needs two less lines of code): ``` 1. Request 2. Log "Request failed" and sleep for the configured retry delay 3. Do actually one more request ```
* As requested in the review * Related ticket: https://progress.opensuse.org/issues/125720
As mentioned in os-autoinst#5036 (review) this otherwise breaks outputting JSON.
No concerns by me. |
kraih
reviewed
Mar 20, 2023
* Declare `$res` where is is actually used * Fix naming of command object
kraih
approved these changes
Mar 20, 2023
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Mar 21, 2023
commit 529c547 Merge: 84fc5a7 2a8981b Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Mon Mar 20 18:52:16 2023 +0000 Commit: GitHub <noreply@github.com> CommitDate: Mon Mar 20 18:52:16 2023 +0000 Merge pull request os-autoinst#5036 from Martchus/schedule-iso Allow scheduling and monitoring a product via `openqa-cli`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://progress.opensuse.org/issues/125720
Example invocation:
So one can use CLI-flags similar to
openqa-cli api.Still a draft because unit tests are missing and the error handling needs to be improved (it should retry like
openqa-cli api).