Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[envtest]Improve coverage #63

Merged
merged 8 commits into from
Sep 21, 2023
Merged

[envtest]Improve coverage #63

merged 8 commits into from
Sep 21, 2023

Commits on Sep 21, 2023

  1. [envtest]Assert all conditions initialized

    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0026669 View commit details
    Browse the repository at this point in the history

  2. [envtest]Show that secret fields are not checked 

    This adds a test case to show that placement-operator does not ensure
that the expected fields are in the provided secret so it can generate
wrong dbsync job configuration.
    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    36351d1 View commit details
    Browse the repository at this point in the history

  3. [envtest]Add coverage for the happy deployment path 

    This increased or coverage from 38 to 70 percent
    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4b78066 View commit details
    Browse the repository at this point in the history

  4. [envtest]Cover ServiceAccount, Role and RoleBinding creation

    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4c09052 View commit details
    Browse the repository at this point in the history

  5. [envtest][refactor]Pull out name handling 

    This is needed as we want to switch from the hardcoded "placement"
PlacementAPI name to a generated one
    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    607881e View commit details
    Browse the repository at this point in the history

  6. [envtest]Switch to generated PlacementAPI Name 

    This has two benefits:
* shows where placement-operator hardcodes names instead of using the
  name of the PlacementAPI CR like in case of the db sync Job and the
  Deployment.
* allows more test case independency
    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    335ae72 View commit details
    Browse the repository at this point in the history

  7. [envtest]Run test in random order 

    Now that the test global variable handling is improved the test can run
in any order.
    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    cb82109 View commit details
    Browse the repository at this point in the history

  8. [envtest]Test delete removing finalizers

    @gibizer
    gibizer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    1f33842 View commit details
    Browse the repository at this point in the history