[envtest]Improve coverage #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibizer
force-pushed
the
envtest-improvements
branch
2 times, most recently
from
8aef5ae
to
4d1437a
Compare
This adds a test case to show that placement-operator does not ensure that the expected fields are in the provided secret so it can generate wrong dbsync job configuration.
This increased or coverage from 38 to 70 percent
This is needed as we want to switch from the hardcoded "placement" PlacementAPI name to a generated one
This has two benefits: * shows where placement-operator hardcodes names instead of using the name of the PlacementAPI CR like in case of the db sync Job and the Deployment. * allows more test case independency
Now that the test global variable handling is improved the test can run in any order.
gibizer
force-pushed
the
envtest-improvements
branch
from
4d1437a
to
1f33842
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrKisaoLamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 98b1b73
into
openstack-k8s-operators:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now at least covering the happy deployment path.
Related: https://issues.redhat.com/browse/OSPRH-108