Remove init flow #135
Remove init flow #135
Conversation
|
Skipping CI for Draft Pull Request. |
mrkisaolamb
force-pushed
the
remove-init-flow
branch
2 times, most recently
from
6ac6dfd
to
ddbdc9c
Compare
mrkisaolamb
force-pushed
the
remove-init-flow
branch
from
ddbdc9c
to
139e935
Compare
mrkisaolamb
force-pushed
the
remove-init-flow
branch
2 times, most recently
from
34032ef
to
5166e15
Compare
mrkisaolamb
force-pushed
the
remove-init-flow
branch
from
5166e15
to
9acac16
Compare
|
/retest |
mrkisaolamb
force-pushed
the
remove-init-flow
branch
4 times, most recently
from
67025b3
to
69401dc
Compare
mrkisaolamb
force-pushed
the
remove-init-flow
branch
3 times, most recently
from
d924516
to
8076033
Compare
| if (err != nil || result != ctrl.Result{}) { | ||
| // We can ignore RequeueAfter as we are watching the Service resource | ||
| // but we have to return while waiting for the service to be exposed | ||
| return ctrl.Result{}, err | ||
| } |
There was a problem hiding this comment.
The comment here is not reflecting the reality. I think you are waiting for the db sync to finish before doing the deployment.
There was a problem hiding this comment.
But also I think the whole if is pointless as if there is an error then we returning at L450, if there is a requeue request from the db sync then we are returning at L452. So we will arrive here with an error or a requeue.
| @@ -2,25 +2,25 @@ | |||
| "command": "/usr/sbin/httpd -DFOREGROUND", | |||
| "config_files": [ | |||
| { | |||
| "source": "/var/lib/config-data/merged/placement.conf", | |||
| "source": "/var/lib/config-data/placement.conf", | |||
| "dest": "/etc/placement/placement.conf", | |||
There was a problem hiding this comment.
Eventually we want to use /etc/placement/placement.conf.d/ but that can be done separately. Also at that point we want to put an empty file to /etc/placement/placement.conf as the container image put the generated sample config file there.
There was a problem hiding this comment.
ack, should I create new issue or this will be handle as a part of different feature/issue?
There was a problem hiding this comment.
please either create an issue or a quick follow up PR
mrkisaolamb
force-pushed
the
remove-init-flow
branch
2 times, most recently
from
41540b8
to
33e435c
Compare
|
/test placement-operator-build-deploy-kuttl i think the test is racy and its not waiting long enough for it to scale we may need to merge #125 first or modify how kuttl is run placement_kuttl_run https://github.com/openstack-k8s-operators/install_yamls/blob/60c1fb7828a91545e52b5c799162bcc21c3dd5ee/Makefile#L1586-L1588 its currently looking for kuttl config in repo in https://github.com/openstack-k8s-operators/placement-operator/blob/main/kuttl-test.yaml so we can adjust some of the config that way nova is using a timeout of 300 seconds per test we are using 180 in placement so we could start by bumping to 300 and see if that is enough to stableise the test |
SeanMooney
dismissed
their stale review
the secuirty context thing is fixed so i think if we dont land on a slow node this will pass
mrkisaolamb
force-pushed
the
remove-init-flow
branch
from
33e435c
to
18fc0ca
Compare
Thanks! I bumped it to 300 because this failed already few times on same issue that db sync didn't finished |
|
kuttl tests catch realll issue with volumes for db-sync so this is not related to timeout |
mrkisaolamb
force-pushed
the
remove-init-flow
branch
3 times, most recently
from
bb6f196
to
75540e2
Compare
|
/retest |
mrkisaolamb
force-pushed
the
remove-init-flow
branch
from
75540e2
to
0df1a65
Compare
mrkisaolamb
force-pushed
the
remove-init-flow
branch
from
0df1a65
to
fa32909
Compare
pkg/placement/volumes.go
Outdated
| { | ||
| Name: "config-data-merged", | ||
| Name: "config-data", | ||
| MountPath: "/var/lib/config-data/merged", |
There was a problem hiding this comment.
lets do a separate follow up where the merged postfix is removed from the mount path. That naming is the from the past where the init container merged configuration.
| annotations: | ||
| openshift.io/scc: anyuid | ||
| labels: | ||
| service: placement |
There was a problem hiding this comment.
Why we dropped the Pod assert? I guess we still have the same placement api pod running
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4285571
into
openstack-k8s-operators:main
No description provided.