Fix scripts volum issue

openstack-k8s-operators · Feb 5, 2024 · 0df1a65 · 0df1a65
1 parent 04516ed
commit 0df1a65
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 18 deletions.
diff --git a/controllers/placementapi_controller.go b/controllers/placementapi_controller.go
@@ -431,7 +431,9 @@ func (r *PlacementAPIReconciler) Reconcile(ctx context.Context, req ctrl.Request
 
 	apiEndpoints, result, err := r.ensureServiceExposed(ctx, h, instance)
 
-	if err != nil {
+	if (err != nil || result != ctrl.Result{}) {
+		// We can ignore RequeueAfter as we are watching the Service resource
+		// but we have to return while waiting for the service to be exposed
 		return ctrl.Result{}, err
 	}
 
@@ -441,10 +443,10 @@ func (r *PlacementAPIReconciler) Reconcile(ctx context.Context, req ctrl.Request
 	}
 
 	result, err = r.ensureKeystoneEndpoint(ctx, h, instance, apiEndpoints)
-	if err != nil {
+	if (err != nil || result != ctrl.Result{}) {
+		// We can ignore RequeueAfter as we are watching the KeystoneEndpoint resource
 		return ctrl.Result{}, err
 	}
-
 	result, err = r.ensureDbSync(ctx, instance, h, serviceAnnotations)
 	if (err != nil || result != ctrl.Result{}) {
 		return result, err
@@ -482,6 +484,7 @@ func (r *PlacementAPIReconciler) ensureServiceExposed(
 	}
 	apiEndpoints := make(map[string]string)
 
+	serviceLabels := getServiceLabels(instance)
 	for endpointType, data := range placementEndpoints {
 		endpointTypeStr := string(endpointType)
 		endpointName := placement.ServiceName + "-" + endpointTypeStr
@@ -492,7 +495,7 @@ func (r *PlacementAPIReconciler) ensureServiceExposed(
 		}
 
 		exportLabels := util.MergeStringMaps(
-			getServiceLabels(instance),
+			serviceLabels,
 			map[string]string{
 				service.AnnotationEndpointKey: endpointTypeStr,
 			},
@@ -504,7 +507,7 @@ func (r *PlacementAPIReconciler) ensureServiceExposed(
 				Name:      endpointName,
 				Namespace: instance.Namespace,
 				Labels:    exportLabels,
-				Selector:  getServiceLabels(instance),
+				Selector:  serviceLabels,
 				Port: service.GenericServicePort{
 					Name:     endpointName,
 					Port:     data.Port,
@@ -522,7 +525,7 @@ func (r *PlacementAPIReconciler) ensureServiceExposed(
 				condition.ExposeServiceReadyErrorMessage,
 				err.Error()))
 
-			return nil, ctrl.Result{}, err
+			return apiEndpoints, ctrl.Result{}, err
 		}
 
 		svc.AddAnnotation(map[string]string{
@@ -554,14 +557,14 @@ func (r *PlacementAPIReconciler) ensureServiceExposed(
 				condition.ExposeServiceReadyErrorMessage,
 				err.Error()))
 
-			return nil, ctrlResult, err
+			return apiEndpoints, ctrlResult, err
 		} else if (ctrlResult != ctrl.Result{}) {
 			instance.Status.Conditions.Set(condition.FalseCondition(
 				condition.ExposeServiceReadyCondition,
 				condition.RequestedReason,
 				condition.SeverityInfo,
 				condition.ExposeServiceReadyRunningMessage))
-			return nil, ctrlResult, nil
+			return apiEndpoints, ctrlResult, nil
 		}
 		// create service - end
 
@@ -574,7 +577,7 @@ func (r *PlacementAPIReconciler) ensureServiceExposed(
 		apiEndpoints[string(endpointType)], err = svc.GetAPIEndpoint(
 			svcOverride.EndpointURL, data.Protocol, data.Path)
 		if err != nil {
-			return nil, ctrl.Result{}, err
+			return apiEndpoints, ctrl.Result{}, err
 		}
 	}
 

diff --git a/pkg/placement/volumes.go b/pkg/placement/volumes.go
@@ -28,11 +28,9 @@ func getVolumes(name string) []corev1.Volume {
 		{
 			Name: "scripts",
 			VolumeSource: corev1.VolumeSource{
-				ConfigMap: &corev1.ConfigMapVolumeSource{
+				Secret: &corev1.SecretVolumeSource{
 					DefaultMode: &scriptsVolumeDefaultMode,
-					LocalObjectReference: corev1.LocalObjectReference{
-						Name: name + "-scripts",
-					},
+					SecretName:  name + "-scripts",
 				},
 			},
 		},

diff --git a/tests/kuttl/common/assert_sample_deployment.yaml b/tests/kuttl/common/assert_sample_deployment.yaml
@@ -142,14 +142,14 @@ spec:
         - mountPath: /usr/local/bin/container-scripts
           name: scripts
           readOnly: true
+        - mountPath: /var/log/placement
+          name: logs
         - mountPath: /var/lib/config-data/
           name: config-data
         - mountPath: /var/lib/kolla/config_files/config.json
           name: config-data
           readOnly: true
           subPath: placement-api-config.json
-        - mountPath: /var/log/placement
-          name: logs
       - args:
         - -c
         - /usr/local/bin/kolla_start

diff --git a/tests/kuttl/common/errors_cleanup_placement.yaml b/tests/kuttl/common/errors_cleanup_placement.yaml
@@ -18,6 +18,15 @@ kind: Deployment
 metadata:
   name: placement
 ---
+# the openshift annotations can't be checked through the deployment above
+apiVersion: v1
+kind: Pod
+metadata:
+  annotations:
+    openshift.io/scc: anyuid
+  labels:
+    service: placement
+---
 apiVersion: v1
 kind: Service
 metadata:
@@ -62,6 +71,18 @@ spec:
 ---
 apiVersion: v1
 kind: Secret
+metadata:
+  labels:
+    placement.openstack.org/name: placement
+  name: placement-scripts
+  ownerReferences:
+  - blockOwnerDeletion: true
+    controller: true
+    kind: PlacementAPI
+    name: placement
+---
+apiVersion: v1
+kind: Secret
 metadata:
   labels:
     placement.openstack.org/name: placement

diff --git a/tests/kuttl/tests/placement_deploy_tls/03-assert.yaml b/tests/kuttl/tests/placement_deploy_tls/03-assert.yaml
@@ -149,14 +149,14 @@ spec:
         - mountPath: /usr/local/bin/container-scripts
           name: scripts
           readOnly: true
-        - mountPath: /var/lib/config-data
+        - mountPath: /var/log/placement
+          name: logs
+        - mountPath: /var/lib/config-data/
           name: config-data
         - mountPath: /var/lib/kolla/config_files/config.json
           name: config-data
           readOnly: true
           subPath: placement-api-config.json
-        - mountPath: /var/log/placement
-          name: logs
         - mountPath: /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem
           name: combined-ca-bundle
           readOnly: true