Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sumac] fix: remove unnecessary toast notification on adding component (#1490) [FC-0062] #1528

Conversation

navinkarkera
Copy link
Contributor

(cherry picked from commit 033acc4)

Backport of #1490

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 22, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 22, 2024

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@navinkarkera navinkarkera marked this pull request as ready for review November 22, 2024 05:03
@navinkarkera navinkarkera requested a review from a team as a code owner November 22, 2024 05:03
@navinkarkera navinkarkera changed the title fix: remove unnecessary toast notification on adding component (#1490) [sumac] fix: remove unnecessary toast notification on adding component (#1490) Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/sumac.master@13bce7e). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/sumac.master    #1528   +/-   ##
============================================================
  Coverage                             ?   93.21%           
============================================================
  Files                                ?     1050           
  Lines                                ?    20411           
  Branches                             ?     4357           
============================================================
  Hits                                 ?    19027           
  Misses                               ?     1324           
  Partials                             ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bradenmacdonald
Copy link
Contributor

@farhaanbukhsh FYI, backport of a small bugfix.

@bradenmacdonald
Copy link
Contributor

When I test this on a sumac devstack, there is some kind of new weird flicker that it introduces as the editor opens. This isn't happening the same way on sumac.master (The editor does still change size after loading on sumac.master, but it doesn't flicker like this)

It doesn't happen consistently but I managed to get a video of it (see the second text component I add):

Flickering.Editor.mov

@bradenmacdonald
Copy link
Contributor

Actually never mind, it is happening on sumac.master too :/
So it's unrelated to this PR.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this fix. I tested it on my Sumac devstack, and the only issue I found seems unrelated (see above).

@bradenmacdonald bradenmacdonald merged commit d08ef83 into openedx:open-release/sumac.master Nov 22, 2024
8 checks passed
@bradenmacdonald bradenmacdonald deleted the navin/sumac/remove-unnecessary-toast-notification branch November 22, 2024 19:15
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Nov 22, 2024
@bradenmacdonald bradenmacdonald changed the title [sumac] fix: remove unnecessary toast notification on adding component (#1490) [sumac] fix: remove unnecessary toast notification on adding component (#1490) [FC-0062] Nov 22, 2024
@navinkarkera
Copy link
Contributor Author

@bradenmacdonald Yes, even I noticed this sometimes. I think it is the same in master branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants