-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: editor flicker after creating xblock #1529
fix: editor flicker after creating xblock #1529
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
src/editors/hooks.ts
Outdated
// eslint-disable-next-line react-hooks/rules-of-hooks | ||
export const initializeApp = ({ dispatch, data }) => useEffect( | ||
() => dispatch(thunkActions.app.initialize(data)), | ||
[data], | ||
[data?.blockId], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be safe, I think you could do [data?.studioEndpointUrl, data?.blockId, data?.learningContextId]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
449f6f0
to
ad45f8e
Compare
ad45f8e
to
3437fb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good 👍
- I tested this: I followed the testing instructions. I verified that the bug does not occur.
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
1c82a67
into
openedx:open-release/sumac.master
Backport of #1531
Description
This PR fixes the flicker bug described here: #1528 (comment)
Flickering.Editor.mov
Additional Information
The
data
object is being mutated with the same value, causing the components to re-render.Note: There is a racing condition involved, so the flicker doesn't happen consistently.
Testing instructions