RHOAIENG-14784: tests(odh-notebook-controller): add upgrade test that compares controller does not modify deployed pods during upgrade #430
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -78,3 +79,5 @@ require ( | |||
| ) | |||
|
|
|||
| replace google.golang.org/grpc => google.golang.org/grpc v1.56.3 | |||
|
|
|||
| replace github.com/kubeflow/kubeflow/components/notebook-controller => ../notebook-controller | |||
There was a problem hiding this comment.
if we don't want to do this, I can put the test directly under components/ as a separate component; but I'd still like to do it this way, so if there's no opposition to the general direction, I'd like to go test it out in cpaas
|
ready now to be looked over |
There was a problem hiding this comment.
yeah, we probably want to filter the stored CRs, this csv is not used for anything, so it should be kept out of git
| //_ = Step("", func() string { | ||
| // return "baf" | ||
| //}) | ||
|
|
There was a problem hiding this comment.
| //_ = Step("", func() string { | |
| // return "baf" | |
| //}) |
There was a problem hiding this comment.
/test odh-notebook-controller-e2e
|
Wow this is huge PR, we need to set a meeting to review that! |
If we don't want to do this, we can make upgrade test a new component under /components next to the controllers, no problem
…eak something by accident
some v2 stuff still leaked in, fixing that
add missing err checks
… CRD since our test values don't pass it
increase timeouts, 10s may not be enough in rare cases
…nt to leak something by accident adding also the dockercfg secrets because they just have creds against the internal registry
jiridanek
force-pushed
the
jd_update_test_spike
branch
from
3c6f361
to
f8e58df
Compare
https://issues.redhat.com/browse/RHOAIENG-14784
Description
It would be nice if we could test upgrade directly in the repository, without having to build container images, bundle, iib, and then deploying the entire rhoai.
Otherwise it would be hard to ensure e.g. no workbench pods restart on upgrade, which is (probably) a requirement we have.
Here's that test presented for your consideration.
The idea is to load YAMLs from an older version where notebook is deployed and controller has done its thing, and then start a new version of the controller over these yamls, and check what did and did not change in the CRs.
How Has This Been Tested?
notebook-controllerfromodh-notebook-controller's tests. This is essentially a subset of the RHOAI-xxx changes that @rkpattnaik780 (of fond memories) tried to make early this year and it failed CPaaS builds. I know how to check for it ahead of time, so if we decide to go with it, I can test CPaaS build pre-merge and I will figure out how to do the same for Konflux.Merge criteria: