Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-14784: tests(odh-notebook-controller): add upgrade test that compares controller does not modify deployed pods during upgrade #430

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

RHOAIENG-14784: tests(odh-notebook-controller): add upgrade test that compares controller does not modify deployed pods during upgrade #430

wants to merge 14 commits into from

Commits on Nov 24, 2024

  1. add notebook-controller as test dep for odh-notebook-controller upgrade 

    If we don't want to do this, we can make upgrade test a new component under /components next to the controllers, no problem
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    a82e955 View commit details
    Browse the repository at this point in the history

  2. dump of 2.13.0 YAMLs, without suspicious secrets as I don't want to l… 

    …eak something by accident
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    029b68d View commit details
    Browse the repository at this point in the history

  3. commit README.md about upgrade tests

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    1986b34 View commit details
    Browse the repository at this point in the history

  4. commit the tests themselves, using ginkgo v1

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    c3db827 View commit details
    Browse the repository at this point in the history

  5. add test to makefile, gingko v1 version

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    d383c19 View commit details
    Browse the repository at this point in the history

  6. fixup gomod as I'm now using prometheus and go-cmp directly

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    14fb2e7 View commit details
    Browse the repository at this point in the history

  7. fixup! commit the tests themselves, using ginkgo v1 

    some v2 stuff still leaked in, fixing that
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    a4dea5b View commit details
    Browse the repository at this point in the history

  8. fixup! commit the tests themselves, using ginkgo v1 

    add missing err checks
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    d6bcff1 View commit details
    Browse the repository at this point in the history

  9. update to latest route crd

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    13abd6d View commit details
    Browse the repository at this point in the history

  10. NO-JIRA: temporarily comment out proper host name validation in route… 

    … CRD since our test values don't pass it
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    fb92efe View commit details
    Browse the repository at this point in the history

  11. fixup! add test to makefile, gingko v1 version 

    increase timeouts, 10s may not be enough in rare cases
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    673c222 View commit details
    Browse the repository at this point in the history

  12. fixup! dump of 2.13.0 YAMLs, without suspicious secrets as I don't wa… 

    …nt to leak something by accident

adding also the dockercfg secrets because they just have creds against the internal registry
    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    12fbd31 View commit details
    Browse the repository at this point in the history

  13. enable culling controller

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    fc3b1b9 View commit details
    Browse the repository at this point in the history

  14. extract stability check

    @jiridanek
    jiridanek committed Nov 24, 2024
    Configuration menu
    Copy the full SHA
    f8e58df View commit details
    Browse the repository at this point in the history