Fixed pkg-config files generation #243
Open
+20
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg-config
files are generated with hardcoded paths to libs and includes.I.e. if I build level-zero on one machine with non-default paths and try to use such package on another, paths will be broken.
It's valid for conda-forge, which builds packages within internal structure and then paths look like:
which cannot be used by users of
level-zero-devel
package.The solution is to use relative paths.
Renamed
utils
tolevel_zero_utils
asutils
is quite common name and clashes with other projects whenlevel-zero
is used as sub-project in a bigger project.Use
PUBLIC
/PRIVATE
when link libraries to hide private libraries likeutils