Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pkg-config files generation #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Nov 20, 2024

  1. Currently, pkg-config files are generated with hardcoded paths to libs and includes.

I.e. if I build level-zero on one machine with non-default paths and try to use such package on another, paths will be broken.
It's valid for conda-forge, which builds packages within internal structure and then paths look like:

/home/conda/feedstock_root/build_artifacts/intel-level-zero_1732035758241/work/install/include

which cannot be used by users of level-zero-devel package.

The solution is to use relative paths.

  1. Renamed utils to level_zero_utils as utils is quite common name and clashes with other projects when level-zero is used as sub-project in a bigger project.

  2. Use PUBLIC / PRIVATE when link libraries to hide private libraries like utils

@ilya-lavrenov
Copy link
Contributor Author

@lisanna-dettwyler please, have a look

@lisanna-dettwyler lisanna-dettwyler self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants