Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 2024.5.0 #110

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Conversation

artanokhov
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@artanokhov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

recipe/meta.yaml Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov self-assigned this Nov 19, 2024
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
Removed yaml-cpp as dependency.
Fixed path for level-zero
@artanokhov artanokhov added the automerge Merge the PR when CI passes label Nov 20, 2024
github-merge-queue bot pushed a commit to openvinotoolkit/openvino that referenced this pull request Nov 20, 2024
@conda-forge-curator conda-forge-curator bot removed the automerge Merge the PR when CI passes label Nov 20, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 20, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ The recipe is not parsable by any of the known recipe parsers (['conda-forge-tick (the bot)', 'conda-recipe-manager', 'conda-souschef (grayskull)']). Please check the logs for more information and ensure your recipe can be parsed.

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-forge-tick (the bot). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12069274925. Examine the logs at this URL for more detail.

@artanokhov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@artanokhov
Copy link
Contributor Author

artanokhov commented Nov 20, 2024

So I assume we have bug in reporting linter status

At first I didn't found the linter issue in the recipe and decided to rerender and try to refresh the linter status with some commit, and in the logs we have green status
https://github.com/conda-forge/conda-forge-webservices/actions/runs/11939083258

But it is still red here, in addition in the build itself the recipe has been parsed
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1086356&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc

@hmaarrfk @xhochy Could you please take a look?

@xhochy
Copy link
Member

xhochy commented Nov 21, 2024

This can be a real bug, but I don't know where you could find the logs. The error indicates that the @regro-cf-autotick-bot will not be able to propose any PRs to this repository. You can still merge though, but it is generally recommended to simplify the recipe a bit so that it gets parsable by these tools.

@artanokhov
Copy link
Contributor Author

This can be a real bug, but I don't know where you could find the logs. The error indicates that the @regro-cf-autotick-bot will not be able to propose any PRs to this repository. You can still merge though, but it is generally recommended to simplify the recipe a bit so that it gets parsable by these tools.

I don't think it's valid errors because if you take a look into changes in the meta.yml - they are common(changed hashes for repos, updated deps, updates in maintainers list).
Is there any possibility to (manually) re-scan the recipe with linters to check what exactly should be tuned/fixed?

@xhochy
Copy link
Member

xhochy commented Nov 22, 2024

I don't think it's valid errors because if you take a look into changes in the meta.yml

It's not due to the changes but simply due to new checks added to the linter.

@artanokhov
Copy link
Contributor Author

artanokhov commented Nov 22, 2024

It's not due to the changes but simply due to new checks added to the linter.

Could you please clarify - are there any recommendations how to simplify the recipe?
Or maybe description of new requirements to pass the linter?

@xhochy
Copy link
Member

xhochy commented Nov 22, 2024

The linter message is currently too simple, ignore it for now and wait until it gets updated to provide more information.

@artanokhov
Copy link
Contributor Author

artanokhov commented Nov 22, 2024

The linter message is currently too simple, ignore it for now and wait until it gets updated to provide more information.

Got it! Thank you!

NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
Trying to add more space on Win hosts.
@artanokhov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@xhochy
Copy link
Member

xhochy commented Nov 28, 2024

The linter message is currently too simple, ignore it for now and wait until it gets updated to provide more information.

The linter now includes a link to its run and you can inspect the logs. Now you can look into it whether it is something that is fixable (quite often souschef trips over things that you cannot fix and should be fixed there instead of the recipe)

@artanokhov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@artanokhov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@artanokhov
Copy link
Contributor Author

artanokhov commented Nov 28, 2024

The linter now includes a link to its run and you can inspect the logs. Now you can look into it whether it is something that is fixable (quite often souschef trips over things that you cannot fix and should be fixed there instead of the recipe)

So, I see issues now - thanks.
It seems like following construction can't be parsed

    test:
      commands:
        {% set openvino_libs = [] %}
        {{ openvino_libs.append("") or "" }}
        {{ openvino_libs.append("_c") or "" }}
        {% for openvino_lib in openvino_libs %}
        - test -f $PREFIX/lib/libopenvino{{ openvino_lib }}${SHLIB_EXT}.{{ version_postfix }}  # [linux]
        - test -f $PREFIX/lib/libopenvino{{ openvino_lib }}.{{ version_postfix }}${SHLIB_EXT}  # [osx]
        - if not exist %LIBRARY_BIN%\\openvino{{ openvino_lib }}%SHLIB_EXT% exit 1  # [win]
        {% endfor %}

because of jinja-blocks inside
yaml-linter expect that all commands inside the block will start with -

@artanokhov
Copy link
Contributor Author

@conda-forge-admin, please rerender

@artanokhov
Copy link
Contributor Author

because of jinja-blocks inside yaml-linter expect that all commands inside the block will start with -

I've removed the blocks but the linter doesn't rerun or the comment doesn't updated properly with new link
FYI @xhochy

@xhochy
Copy link
Member

xhochy commented Nov 28, 2024

It actually looks like it run: https://github.com/conda-forge/conda-forge-webservices/actions/runs/12069274925/job/33656184032

@xhochy
Copy link
Member

xhochy commented Nov 28, 2024

The comment is auto-updating

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12069390173. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12069683030. Examine the logs at this URL for more detail.

@artanokhov
Copy link
Contributor Author

So, currently linter is green but in the logs I see that probably there is an error in the conda-recipe-manager parser itself

Traceback (most recent call last):
  File "/opt/conda/envs/cf-feedstock-ops/lib/python3.11/site-packages/conda_smithy/linter/lints.py", line 1069, in lint_recipe_is_parsable
    RecipeParser(recipe_text)
  File "/opt/conda/envs/cf-feedstock-ops/lib/python3.11/site-packages/conda_recipe_manager/parser/recipe_reader.py", line 4[83](https://github.com/conda-forge/conda-forge-webservices/actions/runs/12069683030/job/33657483944#step:5:85), in __init__
    parent = node_stack[-1]
             ~~~~~~~~~~^^^^
IndexError: list index out of range

@xhochy
Copy link
Member

xhochy commented Nov 28, 2024

currently linter is green but in the logs

The run will always pass so that it can post the message here.

@artanokhov artanokhov added the automerge Merge the PR when CI passes label Nov 28, 2024
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 28, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@conda-forge-admin conda-forge-admin merged commit 45d0b46 into conda-forge:main Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants