[nrf toup] Reduce Packet Buffer Pool size to 11 #507
Conversation
| @@ -48,7 +48,7 @@ struct ChipDeviceEvent; | |||
| #define CHIP_SYSTEM_CONFIG_USE_SOCKETS 1 | |||
|
|
|||
| #ifndef CONFIG_ARCH_POSIX | |||
| #define CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE 15 | |||
| #define CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE 11 | |||
There was a problem hiding this comment.
Is this selected based on the top usage in tests?
There was a problem hiding this comment.
Also, please fill in this info in the commit description :)
There was a problem hiding this comment.
As this is not yet targeted for 2.8.0 and we have a bit of time - what do you think to introduce a KConfig for this configuration?
There was a problem hiding this comment.
As this is not yet targeted for 2.8.0 and we have a bit of time - what do you think to introduce a KConfig for this configuration?
Good idea.
Is this selected based on the top usage in tests?
Yes, highest observed pool usage was 10. I updated commit description.
Add `CHIP_SYSTEM_PACKETBUFFER_POOL_SIZE` Kconfig for packet buffer pool size configuration. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Value selected based on top usage in tests. Highest observed number of packet buffers was 10. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
adigie
force-pushed
the
optimize-memory-usage
branch
from
5f3a9cb
to
94ebf53
Compare
| int "Packet buffer pool size" | ||
| default 11 | ||
| help | ||
| Total number of packet buffers. |
There was a problem hiding this comment.
I wonder if we can describe it a little bit more. For example, describe the purposes for which those packet buffers will be used.
No description provided.