-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: matter: Reduce memory usage #18554
base: main
Are you sure you want to change the base?
Conversation
adigie
commented
Nov 5, 2024
•
edited
Loading
edited
- Remove custom heap size from nRF54L15 configs.
- Reduce Packet Buffer Pool size to 11.
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 498ab89990f04b732bc5f1a0f6ba715302d19ee8 more detailssdk-nrf:
matter:
Github labels
List of changed files detected by CI (18)
Outputs:ToolchainVersion: 8611848abf Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
1c4929b
to
efa71d3
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
@@ -8,7 +8,7 @@ | |||
CONFIG_BT_LL_SOFTDEVICE_MULTIROLE=y | |||
|
|||
# nRF54L15 requires bigger stack sizes than nRF52/nRF53 families | |||
CONFIG_CHIP_MALLOC_SYS_HEAP_SIZE=10240 | |||
CONFIG_CHIP_MALLOC_SYS_HEAP_SIZE=7168 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can remove this line completely and have a default values in sdk-connectedhomeip only (potentially different for nRF52/53/54).
Btw. In this PR you have changes configuration only for nRF54L15 - what about 52 and 53?
Also i believe we should run nightly on this PR before merging - as previously some of the Matter tests were failing (maybe its not the case anymore): cdcb580
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can. We will use default configuration for all platforms - 8KB.
Use default heap size on nRF54L15. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
efa71d3
to
b5ba2cc
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
* Add Kconfig for packet buffer pool size. * Reduce packet buffer pool size to 11. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
b5ba2cc
to
68fbb87
Compare
doc/nrf/protocols/matter/getting_started/memory_optimization.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/memory_optimization.rst
Outdated
Show resolved
Hide resolved
Mention `CONFIG_CHIP_SYSTEM_PACKETBUFFER_POOL_SIZE` Kconfig option. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
68fbb87
to
498ab89
Compare
I'll hold on approving for a bit since I'm also part of ncs-matter, so one of the guys can properly approve. |