Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to fmmax.utils.eig #19

Merged
merged 8 commits into from
May 8, 2024
Merged

Move to fmmax.utils.eig #19

merged 8 commits into from
May 8, 2024

Conversation

SamDuffield
Copy link
Contributor

fmmax.utils.eig is jit-able and differentiable and allows us to remove the A_spd argument (which was difficult because for dense D then A_y is likely not symmetric positive definite anyway.

@SamDuffield SamDuffield requested a review from KaelanDt May 8, 2024 15:12
KaelanDt and others added 5 commits May 8, 2024 18:59
@KaelanDt @SamDuffield
rename and cleanup thermodynamic_linear_algebra + add readme for ex…
6ed5982 
…amples (#18)

* rename and cleanup `thermodynamic_linear_algebra`
notebook, add readme for examples

* fix names in notebooks
@SamDuffield
expnegm in notebook
aa565fd
@SamDuffield
Revert "expnegm in notebook"
8cbe847 
This reverts commit aa565fd.
@SamDuffield
Revert "rename and cleanup thermodynamic_linear_algebra + add readm…
320b333 
…e for examples (#18)"

This reverts commit 6ed5982.
@SamDuffield
Revert "expnegm in notebook"
0df4fa0 
This reverts commit b02f38c.
KaelanDt
KaelanDt reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one minor comment)

tests/test_log_prob.py Outdated Show resolved Hide resolved
KaelanDt
KaelanDt approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@SamDuffield SamDuffield merged commit f230764 into main May 8, 2024
2 checks passed
@SamDuffield SamDuffield deleted the diff-eig branch May 8, 2024 18:19
@SamDuffield SamDuffield mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelanDt KaelanDt KaelanDt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamDuffield @KaelanDt