New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs don't match code #16

Closed

SamDuffield opened this issue May 3, 2024 · 2 comments

Labels

invalid

Contributor

SamDuffield commented May 3, 2024 •

edited

Loading

https://github.com/normal-computing/thermox/blob/23d395cbd2106d6591b155ead8ff43f81a802bfd/thermox/utils.py#L95C6-L95C36

Should it be A_y = D^0.5 @ A @ D^-0.5 or A_y = D-^0.5 @ A @ D^0.5

Contributor Author

SamDuffield commented May 3, 2024

Also A_y might not be positive definite anymore after this transformation, we need to check this

SamDuffield added the invalid label

Contributor Author

SamDuffield commented May 9, 2024

Fixed in #19

SamDuffield closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment