Merge back downstream fixes from abandonware #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix comes from noble#84 (comment) , so I can't personally vouch for it. Change-Id: Ifde2a3b996ab89a4b12b0eb155c081aca2b11dc3 Origin: https://github.com/jrobeson/node-bluetooth-hci-socket Forwarded: noble#91
Change-Id: Ide752983f00395cf8cb59ab727a58ff0692112dd Origin: https://github.com/jrobeson/node-bluetooth-hci-socket Forwarded: noble#91
Change-Id: I94fdcbea6957d9f2c7eb5e28d8364363be6a3520 Forwarded: noble#102 Signed-off-by: Philippe Coval <p.coval@samsung.com>
- current Zadig advice "Delete the driver software for this device" - Zadig tries to create a system restoral point but this usually fails on my Windows 10 (but thanks Zadig for trying) Change-Id: I004df41220c7e12b7cf8b1f1f1a65aab701ffe32 Origin: https://github.com/noble/node-bluetooth-hci-socket/commit/1620b37d47b5168decffbf23c82d6c038a2d0e5a.patch Forwarded: noble#54
Origin: https://github.com/abandonware/node-bluetooth-hci-socket Change-Id: I0b1c9c2a6950fa562c0e59ebdc780960bf219a6a Signed-off-by: Philippe Coval <p.coval@samsung.com>
Before updating revision Change-Id: I4e19251e6ec5ea7d69b2390fe152fe337862ccb3 Forwarded: noble#105 Origin: https://github.com/abandonware/node-bluetooth-hci-socket/ Bug: noble#85 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Might be caused by parallel jobs? ``` > @abandonware/bluetooth-hci-socket@0.5.3-0 install /local/home/philippe/var/cache/url/git/ssh/github.com/tizenteam/node-bluetooth-hci-socket/src/node-bluetooth-hci-socket > node-pre-gyp install --fallback-to-build (...) Release/obj.target/binding/src/BluetoothHciSocket.o: file not recognized: File truncated collect2: error: ld returned 1 exit status (...) ``` Or ``` rm: cannot remove './Release/.deps/Release/obj.target/binding/src/BluetoothHciSocket.o.d.raw': No such file or directory (...) make: *** [Release/obj.target/binding/src/BluetoothHciSocket.o] Error 1 ``` Origin: #4 Relate-to: noble#91 Change-Id: I34726c8adffc7c39f585f42da1f7d776c5761a17 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Change-Id: I5fbe3eb7463edc95bb44558d5874ff2123e7e46c Signed-off-by: Philippe Coval <p.coval@samsung.com>
This was referenced Jan 24, 2020
|
This review is still pending for a year, Can we discuss about maintenance strategy at: |
|
Those changes are released in downstream version: |
|
Would like to see these changes include as well. Currently using the downstream fork by abandonware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate-to: https://abandonware.github.io/