-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update igenomes config #77
Conversation
8db8423
to
3095a64
Compare
I figured out that removing the gtf default value was not the smartest idea, since the nf-core linting is failing now. I'll have a second look at this. |
I feel that you have a template update at the same time. |
Thanks for the hint @maxulysse. I rebased #78 so that we can merge that one first. |
sorry, read the other PR before... 🤦 |
This solves the problem of overwritten gtf values, if they are set via igenomes.
This reverts commit 5e3e123.
a89da97
to
d314af4
Compare
Finally everything should be ready now. |
f6257ae
to
e20442e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I updated the igenomes config because there were some issues concerning
null
values when using igenomes, probably because some of the attributes were missing in the old versionThere are some other things fixed: