Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bundler version conditions #2823

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Add Bundler version conditions #2823

merged 8 commits into from
Aug 21, 2024

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Aug 20, 2024 •
edited
Loading

Bundler 2+ deprecated all_specs in favor of installed_specs and emits warnings when all_specs is used. We still support Bundler 1, so need to keep all_specs around while using installed_specs when appropriate.

Checking for the version proved faster in benchmarking than checking to see if installed_specs is defined.

closes #2733

@hannahramadan hannahramadan changed the title Bundler version conditions Add Bundler version conditions Aug 20, 2024
@hannahramadan hannahramadan marked this pull request as ready for review August 20, 2024 20:08
hannahramadan and others added 3 commits August 20, 2024 13:48
hannahramadan and others added 2 commits August 20, 2024 16:22
@hannahramadan @fallwith
Update lib/new_relic/agent/instrumentation/grape.rb
f01f972 
Co-authored-by: James Bunch <fallwith@gmail.com>
@hannahramadan
parens
8c954c1
fallwith
fallwith previously approved these changes Aug 20, 2024
View reviewed changes
kaylareopelle
kaylareopelle previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, as-is! A few small suggestions.

lib/new_relic/agent/instrumentation/grape.rb Outdated Show resolved Hide resolved
lib/new_relic/language_support.rb Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.82% 93%
Branch 70.35% 50%

kaylareopelle
kaylareopelle approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@hannahramadan hannahramadan merged commit a885001 into dev Aug 21, 2024
32 checks passed
@hannahramadan hannahramadan deleted the shhhh_bundler branch August 21, 2024 18:13
@hannahramadan hannahramadan mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fallwith fallwith fallwith left review comments

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid deprecated Bundler method all_specs
3 participants
@hannahramadan @fallwith @kaylareopelle