Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated Bundler method all_specs #2733

Closed
jcoyne opened this issue Jun 26, 2024 · 6 comments · Fixed by #2823
Closed

Avoid deprecated Bundler method all_specs #2733

jcoyne opened this issue Jun 26, 2024 · 6 comments · Fixed by #2823
Assignees
Labels
community To tag external issues and PRs submitted by the community

Comments

@jcoyne
Copy link

jcoyne commented Jun 26, 2024

 [DEPRECATED] Bundler.rubygems.all_specs has been removed in favor of Bundler.rubygems.installed_specs

This is used in several places:
https://github.com/search?q=repo%3Anewrelic%2Fnewrelic-ruby-agent%20all_specs&type=code

@workato-integration
Copy link

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Jun 26, 2024
@hannahramadan
Copy link
Contributor

Hi @jcoyne! Thank you for letting us know about this. We still support Bundler v1, which doesn’t have the new installed_specs method, so we won’t be able to switch the methods out. However, we will look into silencing this warning for newer Bundler users. For now, I’m going to remove the bug label for housekeeping purposes.

@hannahramadan hannahramadan removed the bug label Jun 27, 2024
@kford-newrelic kford-newrelic moved this from Triage to In Quarter in Ruby Engineering Board Jul 9, 2024
@kford-newrelic kford-newrelic added jul-sep qtr Represents proposed work item for the Jul-Sep quarter and removed jul-sep qtr Represents proposed work item for the Jul-Sep quarter labels Jul 9, 2024
@gstokkink
Copy link

@hannahramadan can't you check whether installed_specs is present and call that instead of all_specs?

@hannahramadan
Copy link
Contributor

Thank you again for sharing this issue with us @jcoyne! We are including a fix for this in our next release, 9.13.0, which should be available within the next week. cc @gstokkink

@gstokkink
Copy link

@hannahramadan thanks for the quick follow-up!

@hannahramadan
Copy link
Contributor

Ruby agent 9.13.0 is live and includes this update.

Closed by: #2823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants