-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resetting PROMPT_START/PROMPT_END on exit #547
Resetting PROMPT_START/PROMPT_END on exit #547
Conversation
Similar findings to #542. |
Tested on F-39 and it works as expected. |
This is also working for me. I hope this gets merged soon, as it is better than #542, since it handles both start AND end. |
Hello. This is working for me. Hope it will be merged. |
It worked for me also, tested on Fedora 39 |
Yeah, at this point the fix has been verified. We just need it to actually get merged by @magicmonty ;) Hopefully soon, but in the meantime I just keep manually applying the fix as needed on my systems. |
I can confirm this worked for me on Fedora 40. |
I can also confirm this works for me on Fedora 40 |
Works for me too on Fedora 40 |
/fixes #539
The issue seems to be caused by the logic here:
bash-git-prompt/gitprompt.sh
Lines 249 to 272 in 51080c2
Basically, the values of both
PROMPT_START
andPROMPT_END
are being set accordingly when entering a git repository, but never being reset to their original values upon exiting.This PR adds a couple lines to capture the original values of
PROMPT_START
andPROMPT_END
on the way in and then resets the values accordingly on the way out.