Skip to content
This repository has been archived by the owner on Feb 28, 2019. It is now read-only.

Adds swagger description fields to MappingRule and RollupRule #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds swagger description fields to MappingRule and RollupRule #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion public/r2/v1/swagger/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,9 @@
"name": {
"type": "string"
},
"description": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this we actually need to make a change to the backend protobuf message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I wanted to make a separate pull request for that (as it's in a different repo I believe). This pull request was mainly to confirm agree on the upcoming API change, and have the changes updated in Swagger.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good. I agree with Xi, we should merge it with the actual implementation so its consistent on master.

Also, I wonder if there is a way to extend an Object in swagger markup. eg MappingRule is implemented by MappingRuleData. Might help on code duplication.

"type": "string"
},
"filter": {
"type": "string"
},
Expand All @@ -853,6 +856,9 @@
"name": {
"type": "string"
},
"description": {
"type": "string"
},
"filter": {
"type": "string"
},
Expand Down Expand Up @@ -882,6 +888,9 @@
"name": {
"type": "string"
},
"description": {
"type": "string"
},
"filter": {
"type": "string"
},
Expand All @@ -902,6 +911,9 @@
"name": {
"type": "string"
},
"description": {
"type": "string"
},
"filter": {
"type": "string"
},
Expand Down Expand Up @@ -957,4 +969,4 @@
}
}
}
}
}