This repository has been archived by the owner on Feb 28, 2019. It is now read-only.
Adds swagger description fields to MappingRule and RollupRule #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rresponding Data models)
xichen2020
reviewed
Oct 18, 2017
| @@ -836,6 +836,9 @@ | |||
| "name": { | |||
| "type": "string" | |||
| }, | |||
| "description": { | |||
There was a problem hiding this comment.
For this we actually need to make a change to the backend protobuf message.
There was a problem hiding this comment.
Yup, I wanted to make a separate pull request for that (as it's in a different repo I believe). This pull request was mainly to confirm agree on the upcoming API change, and have the changes updated in Swagger.
There was a problem hiding this comment.
Cool, looks good. I agree with Xi, we should merge it with the actual implementation so its consistent on master.
Also, I wonder if there is a way to extend an Object in swagger markup. eg MappingRule is implemented by MappingRuleData. Might help on code duplication.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds swagger description fields to MappingRule and RollupRule and their corresponding data models (MappingRuleData, RollupRuleData)