Added APFS support #314 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
+ Coverage 87.83% 87.99% +0.15%
==========================================
Files 192 202 +10
Lines 8824 9260 +436
==========================================
+ Hits 7751 8148 +397
- Misses 1073 1112 +39
Continue to review full report at Codecov.
|
|
Holding off on review until checks pass |
joachimmetz
force-pushed
the
apfs
branch
2 times, most recently
from
0c538ad
to
faa880a
Compare
joachimmetz
force-pushed
the
apfs
branch
2 times, most recently
from
7ce37dc
to
15a6cdf
Compare
Onager
requested changes
Nov 23, 2018
|
|
||
| parent_path_spec = getattr(self.path_spec, 'parent', None) | ||
| path_spec = apfs_path_spec.APFSPathSpec( | ||
| location=parent_location, identifier=parent_identifier, |
There was a problem hiding this comment.
parent_location will be uninitialized here if location is None - what's supposed to happen in that unlikely situation?
There was a problem hiding this comment.
apfs_path_spec.APFSPathSpec will raise ValueError if location and identifier are None. Let me fix parent_location not being initialized.
|
@Onager PTAL |
Onager
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #319
Added APFS support #314