Added APFS encryption support #314 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 88.02% 88.04% +0.02%
==========================================
Files 202 203 +1
Lines 9259 9278 +19
==========================================
+ Hits 8150 8169 +19
Misses 1109 1109
Continue to review full report at Codecov.
|
joachimmetz
changed the title
Onager
requested changes
Nov 23, 2018
dfvfs/lib/apfs_helper.py
Outdated
| @@ -30,3 +30,21 @@ def APFSContainerPathSpecGetVolumeIndex(path_spec): | |||
| volume_index = None | |||
|
|
|||
| return volume_index | |||
|
|
|||
|
|
|||
| def APFSContainerOpenVolume(apfs_volume, path_spec, key_chain): | |||
There was a problem hiding this comment.
This doesn't actually open the volume, unlike the similar methods for bde and fvde. Please rename the method (APFSContainerUnlockVolume?) and update the docstring.
Onager
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added encrypted APFS support #314
Requires: #317