Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when username doesn't exist on remote and try to create it. #12193

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Adds extra exception handling to handle case where the username does not exist on the remote

References

Fixes #12191

Reviewer guidance

Follow the steps in the issue above ^


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label May 22, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: User Re: User app (sign-in, sign-up, user profile, etc.) SIZE: very small labels May 22, 2024
@pcenov
Copy link
Member

pcenov commented May 23, 2024

Hi @rtibbles - I confirm that the issue described in #12191 is fixed now. I've also regression tested the other migration scenarios without finding any other issues.

@pcenov pcenov self-requested a review May 23, 2024 09:34
@rtibbles rtibbles merged commit 9027de7 into learningequality:release-v0.16.x May 23, 2024
34 checks passed
@rtibbles rtibbles deleted the username_doesnt_exist branch May 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants