Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility > Data - Clicking the "..." (Options) button shifts the Sync button to the left #12186

Closed
pcenov opened this issue May 20, 2024 · 5 comments
Assignees
Labels
APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) bug Behavior is wrong or broken DEV: frontend TAG: regression Something that previously worked

Comments

@pcenov
Copy link
Member

pcenov commented May 20, 2024

Observed behavior

Clicking the "..." (Options) button shifts the Sync button to the left:

sync-options.mp4

I checked the 0.16.1 version of Kolibri and it's not extant there so it must be caused by recent changes.

Expected behavior

The menu should be displayed under the Options button without changing the position of the Sync button

Steps to reproduce the issue

  1. Install Kolibri 0.16.2b2
  2. Go to Facility >Data
  3. Click the "..." (Options) button

Usage Details

Kolibri 0.16.2b2
Windows 11, Ubuntu 22 - Chrome, Firefox

@pcenov
Copy link
Member Author

pcenov commented May 20, 2024

@radinamatic

@radinamatic radinamatic added bug Behavior is wrong or broken APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: frontend labels May 20, 2024
@marcellamaki marcellamaki added the TAG: regression Something that previously worked label May 21, 2024
@marcellamaki marcellamaki self-assigned this May 21, 2024
@marcellamaki
Copy link
Member

Hi @pcenov @radinamatic - I've tried to replicate this on Chrome, Firefox, and Safari, and so far I can't (I think because I'm testing on MacOS). My thought is that there might be a KDS related change that is causing this, but looking through the review notes there isn't any obvious that sticks out right away. Since it doesn't appear to be on every browser and OS, I may downgrade this and have it roll into our next release, as I think the problem may require some KDS tweaks, another KDS release, and an upgrade with QA on windows and ubuntu which would be... rather difficult to do on a tight turn around. What do you think, Radina? (cc @rtibbles )

@pcenov
Copy link
Member Author

pcenov commented May 23, 2024

Hi @marcellamaki I am able to consistently replicate that issue in all OSs and browsers but only when using the official 0.16.2b2 build while when using the build asset from this PR #12193 for example - the issue is not extant - so yeah, there's something strange happening here...

@marcellamaki
Copy link
Member

Let's confirm whether or not it's in the beta3 that I'll be tagging today and we'll decide next steps after that. Thanks Peter! Useful insights as always :)

@pcenov
Copy link
Member Author

pcenov commented May 27, 2024

Hi @marcellamaki I confirm that this issue is not extant in the Beta3 build so I am closing it.

@pcenov pcenov closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) bug Behavior is wrong or broken DEV: frontend TAG: regression Something that previously worked
Projects
None yet
Development

No branches or pull requests

3 participants