Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MOCMC #80

Merged
merged 150 commits into from
Jun 8, 2022
Merged

Add MOCMC #80

merged 150 commits into from
Jun 8, 2022

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Feb 18, 2022

First PR for:

  1. Adding MOCMC sample transport
  2. Interfacing MOCMC outputs (Eddington tensor and frequency-averaged opacities) with existing radiation moments

Some other notes:

src/radiation/moments.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this bad boy in. 👍

@Yurlungur
Copy link
Collaborator

...after tests pass. Looks like still seeing test failures?

Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

for (int k = 0; k < nx_k; k++) {
for (int j = 0; j < nx_j; j++) {
for (int i = 0; i < nx_i; i++) {
starting_index(k, j, i) = index;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be starting_index_h since this isn't inside a par_for region?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely. I should test this PR on GPU in detail, at the moment though it seems like the radiation diffusion test is failing even with M1 (in a way that cuda-gdb doesn't backtrace, annoyingly). I'll look into it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the failure I attributed to radiation was actually due to flux/src diags for fluid still running for an inactive fluid: #115

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK the code runs now but radiation tests fail on GPU. I think we should address this in a subsequent PR. See issue #116.

@brryan brryan merged commit c570f42 into main Jun 8, 2022
@Yurlungur Yurlungur deleted the brryan/add_mocmc branch October 25, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants