-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MOCMC #80
Add MOCMC #80
Conversation
adding code to assign samples a dOmega and compute eddington
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this bad boy in. 👍
...after tests pass. Looks like still seeing test failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
src/radiation/mocmc.cpp
Outdated
for (int k = 0; k < nx_k; k++) { | ||
for (int j = 0; j < nx_j; j++) { | ||
for (int i = 0; i < nx_i; i++) { | ||
starting_index(k, j, i) = index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be starting_index_h
since this isn't inside a par_for
region?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes definitely. I should test this PR on GPU in detail, at the moment though it seems like the radiation diffusion test is failing even with M1 (in a way that cuda-gdb
doesn't backtrace, annoyingly). I'll look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the failure I attributed to radiation was actually due to flux/src diags for fluid still running for an inactive fluid: #115
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK the code runs now but radiation tests fail on GPU. I think we should address this in a subsequent PR. See issue #116.
First PR for:
Some other notes:
singularity-opac
featureB_fake
with a scale-free thermal distribution option for gray opacities insingularity-opac
-- basically it's justc = kb = h = 1
soBnu
still has structure in frequency.Bnu = 2 Ns nu^3 / (Exp(nu / T) + 1)
develop
and update parthenon submodule heredevelop
and update parthenon submodule here