⚠️ Only prevent validation of top-level ObjectMeta field

[arjunrn]

This addresses #385. Currently the validation for ObjectMeta is not generated even if it is used somewhere in the schema other than at the top-level. To fix this I mostly reverted the changes from #266 and then after the schema has been generated patched the top-level metadata to have no validation. The resulting schema for ObjectMeta is still big as @sttts mentions in the issue but I don't see how we can drop only the read-only fields. We can have a hand-written schema with only the required fields but this would need more effort in the long term keeping it in sync with upstream. I'm open to suggestions on how this can be improved.

[arjunrn]

/assign @DirectXMan12

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arjunrn
To complete the pull request process, please assign directxman12
You can assign the PR to them by writing /assign @directxman12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pgier]

FWIW, this patch worked to fix our use case in prometheus-operator (prometheus-operator/prometheus-operator#3041)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[mcristina422]

/remove-lifecycle rotten

[DirectXMan12]

Title edit: this is a breaking change

[k8s-ci-robot]

@arjunrn: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DirectXMan12]

it almost sounds like we want format: x-kubernetes-metadata or something here, longterm

[DirectXMan12]

I think this approach is fairly reasonable, but it is a breaking change. We should have a generator option to turn this on or off, I think. Please add that, and then this is good to go.

[DirectXMan12]

(also, I realize this is super old at this point, so if the original submitter is no longer available and someone wants to take this over, please do)

[sttts]

I still think it is not a good idea to have full ObjectMeta in an embedded object. The technical work around is have some special EmbeddedObjectMeta with a restricted set of fields. I think that's the route that some operators went by now.

[DirectXMan12]

What do we do about PodTemplateSpec, then?

[sttts]

What do we do about PodTemplateSpec, then?

Sins of the past.

Do we have any restriction on PodTemplateSpec in contrast to object-top-level meta data? We should have gone the same way there, i.e. EmbeddedObjectMeta.

[champak]

For operators that are already deployed re-organizing the CRD to add embeddedObjectMeta may not be feasible for an upgrade. If we could keep at least the name/namespace (typically these get referenced by other objects) of the ObjectMeta around post conversion, that would help. #448 Thanks

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[dvaldivia]

/remove-lifecycle rotten

[arjunrn]

Closing in favor of #539