(:warning:, major), Adding an option flag for fixing up object meta-data

[champak]

Added an option for preserving embedded object meta-data ( discussed at #448).

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @champak!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[champak]

@DirectXMan12 just doing a poll; is this what you were describing as needed on #395 ? Thanks

[DirectXMan12]

close to it -- comments inline

[DirectXMan12]

this flag seems to do the inverse of what i'd expect, if I'm reading this right

Here's what I'd expect:

if you pass PreserveObjectMeta, you get an object with no top-level metadata (it's enforced by the apiserver), but all the embedded object metadata fields are filled out.

If you don't pass PreserveObjectMeta, you get the behavior today, which is that all objectmeta fields are wiped.

[champak]

@DirectXMan12 thanks for taking a look ! I probably misunderstood but it had seemed when PreserveObjectMeta is either unspecified or set to false, with this update we would not invoke the new fnc FixupMetaData() and hence the behavior would be what we have today. I shall re-read and flip the check if that is what you meant.

[dvaldivia]

@DirectXMan12 I think the top leve metadata will be rejected by the API server regardless, I thought this PR was about keeping the metadata for embedded ObjectMeta in the CRDs

[dvaldivia]

cc @champak

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: champak
To complete the pull request process, please assign vincepri after the PR has been reviewed.
You can assign the PR to them by writing /assign @vincepri in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dvaldivia]

I'm testing this PR, and I see metadata being generated for the top CRD schema, which causes an error

* spec.versions[1].schema.openAPIV3Schema.properties[metadata]: Forbidden: must not specify anything other than name and generateName, but metadata is implicitly specified

I think this one @DirectXMan12 explicitly mentions not to generate

Also, it seems like metadata. managedFields.fieldsV1 causes some problem, as the kubernetes API is rejecting the CRD with the following problem

* spec.versions[1].schema.openAPIV3Schema.properties[spec].properties[pools].items.properties[volumeClaimTemplate].properties[metadata].properties[managedFields].items.properties[fieldsV1].type: Unsupported value: "Any": supported values: "array", "boolean", "integer", "number", "object", "string"

this error seems valid, I cannot find any reference in the openAPI documentation for this Any type of value

edit:

Changing the fieldsV1 field type to object would fix the issue

tested on
Client Version: v1.20.1
Server Version: v1.19.1

[k8s-ci-robot]

@champak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.