-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk: remove the call to NeedResize #1102
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is refer to the aws ebs driver . |
That does not mean it is good. |
rebased to resolve conflict |
There might be a reason behind it, let's proceed straightforwardly. |
https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/27ac6ca1261e71082f1d2e982d345cdf9b06b58b/pkg/gce-pd-csi-driver/node.go#L381 Google does not check. We also not checking at other place.
So, not checking should be more straightforward. |
It is unnecessary, the Resize itself is idempotent. Get rid of the dependency on blockdev executable.
What type of PR is this?
What this PR does / why we need it:
It is unnecessary, the Resize itself is idempotent. Get rid of the dependency on blockdev executable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: