Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rewrite dockerfile to distroless #1098

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Jun 27, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Only copy necessary binaries.
Cross compile util-linux.
init container is switched to busybox.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

amd64+arm64 only 144MiB

Note that the partition expansion is known broken. growpart is a shell script, but we don't include shell now.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huww98 huww98 force-pushed the rewrite-dockerfile branch 2 times, most recently from 5f79f77 to e801884 Compare June 27, 2024 12:47
@huww98
Copy link
Contributor Author

huww98 commented Jun 27, 2024

/hold
depends on #1057 . We don't have mkdir command now.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@huww98 huww98 force-pushed the rewrite-dockerfile branch 3 times, most recently from d1c475d to d25c1be Compare June 28, 2024 03:55
@huww98
Copy link
Contributor Author

huww98 commented Jun 28, 2024

We still have some more deps to be eliminated:

  • losetup
  • growpart
  • mkdir
  • chmod
  • grep
  • tail
  • blockdev
  • nsenter
    • udevadm
    • iohub-vfhp-helper
    • get_dbfs_mount_path
    • dbfs_get_home_path.sh

@huww98
Copy link
Contributor Author

huww98 commented Jun 28, 2024

/unhold
since I've added mkdir.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2024
@huww98
Copy link
Contributor Author

huww98 commented Jul 1, 2024

should rebase after #1102 got merged. And remove blockdev

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@huww98 huww98 force-pushed the rewrite-dockerfile branch 4 times, most recently from 9e10b37 to bac5200 Compare October 27, 2024 05:35
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2024
With the help of shellcheck
Only copy necessary binaries.
Cross compile util-linux.
init container is switched to busybox.

Note that the partition expansion is known broken. growpart is a shell script, but we don't include shell now.
@huww98
Copy link
Contributor Author

huww98 commented Nov 21, 2024

#1057 is merged, dropping mkdir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants