-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support Multiple Providers #314
Conversation
367fb4e
to
1fc2b82
Compare
I know we discussed replacing the the resources/limits, but looking at this, I wonder if it makes sense to be able to control each individual with its own set of values? If they don't all need to be 1Gi / 1 CPU we can adjust them appropriately. If not I can change it. |
1fc2b82
to
a2af5fc
Compare
@jortel looks like there are some test failures. I noticed you were specifying an image in your personal quay org; will we need the updated image for these tests to pass? |
We'll need hub to be merged, then addon-analyzer to go-mod updated, merged, then the test should pass. |
6567d96
to
85e9a09
Compare
Once I have feedback on the component names and resources I will update those. |
85e9a09
to
570a3b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
df1ec31
to
51165c9
Compare
30ee45b
to
f83a7ad
Compare
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
f83a7ad
to
9b6836b
Compare
@djzager is make bundle being run on the main branch? The CSV being printed out in the logs does not reflect the updates in the PR and the operator is failing to reconcile because it is not creating the Addon with a field that was previously required. |
No description provided.