Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support Multiple Providers #314

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jmontleon
Copy link
Member

No description provided.

@jmontleon jmontleon self-assigned this Jun 3, 2024
@jmontleon jmontleon added this to the v0.5.0 milestone Jun 3, 2024
@jmontleon jmontleon linked an issue Jun 3, 2024 that may be closed by this pull request
@jmontleon jmontleon force-pushed the support-multiple-providers branch 2 times, most recently from 367fb4e to 1fc2b82 Compare June 5, 2024 18:30
@jmontleon
Copy link
Member Author

I know we discussed replacing the the resources/limits, but looking at this, I wonder if it makes sense to be able to control each individual with its own set of values? If they don't all need to be 1Gi / 1 CPU we can adjust them appropriately. If not I can change it.

@jmontleon jmontleon marked this pull request as ready for review June 5, 2024 18:34
@jmontleon
Copy link
Member Author

I don't know if @rayfordj and/or @fbladilo have been made aware that there are a couple of additional images yet, but if not they'd probably appreciate a heads up as well.

@jmontleon
Copy link
Member Author

jmontleon commented Jun 5, 2024

@jortel looks like there are some test failures. I noticed you were specifying an image in your personal quay org; will we need the updated image for these tests to pass?

@jortel
Copy link
Contributor

jortel commented Jun 5, 2024

@jortel looks like there are some test failures. I noticed you were specifying an image in your personal quay org; will we need the updated image for these tests to pass?

We'll need hub to be merged, then addon-analyzer to go-mod updated, merged, then the test should pass.

@jmontleon jmontleon force-pushed the support-multiple-providers branch 2 times, most recently from 6567d96 to 85e9a09 Compare June 6, 2024 13:40
@jmontleon
Copy link
Member Author

Once I have feedback on the component names and resources I will update those.

Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmontleon jmontleon force-pushed the support-multiple-providers branch 2 times, most recently from df1ec31 to 51165c9 Compare June 6, 2024 15:25
@jmontleon jmontleon force-pushed the support-multiple-providers branch 2 times, most recently from 30ee45b to f83a7ad Compare June 6, 2024 21:33
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
@jmontleon
Copy link
Member Author

jmontleon commented Jun 7, 2024

@djzager is make bundle being run on the main branch? The CSV being printed out in the logs does not reflect the updates in the PR and the operator is failing to reconcile because it is not creating the Addon with a field that was previously required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple providers.
3 participants