Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple providers. #313

Closed
jortel opened this issue May 31, 2024 · 3 comments · Fixed by #314
Closed

Support multiple providers. #313

jortel opened this issue May 31, 2024 · 3 comments · Fixed by #314
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@jortel
Copy link
Contributor

jortel commented May 31, 2024

In support multiple providers, the CRDs found here have changed. See pull/606 for latest files.

The installed CRs have also changed found here. See: pull/79 for latest files.

The separation of analyzer and providers mean the addon-analyzer no longer needs as much cpu and memory.

The current variables (and defaults) really apply to the java provider (extension). Let's discuss how to deal with this.

analyzer_container_limits_cpu: "1"
analyzer_container_limits_memory: "4Gi"
analyzer_container_requests_cpu: "1"
analyzer_container_requests_memory: "4Gi"

probably needs new variables?

provider_java_container_limits_cpu: "1"
provider_java_container_limits_memory: "4Gi"
provider_java_container_requests_cpu: "1"
provider_java_container_requests_memory: "4Gi"
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels May 31, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning May 31, 2024
@jortel jortel added the kind/feature Categorizes issue or PR as related to a new feature. label May 31, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label May 31, 2024
@jortel jortel added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels May 31, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label May 31, 2024
@jortel jortel added priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels May 31, 2024
@jortel jortel added this to the v0.5.0 milestone May 31, 2024
@jmontleon jmontleon linked a pull request Jun 3, 2024 that will close this issue
@jmontleon
Copy link
Member

@jortel jortel moved this from 🆕 New to 🔖 Ready in Planning Jun 3, 2024
@jortel jortel moved this from 🔖 Ready to 🏗 In progress in Planning Jun 3, 2024
@jortel
Copy link
Contributor Author

jortel commented Jun 4, 2024

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants