Fix spdlog compile errors #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the project uses C++20 and fmt library is now part of the standard library. Additionally I had compilation errors after upgrading the msvc compiler due to fmt::format lib, so I recompiled spdlog using the SPDLOG_USE_STD_FORMAT cmake flag and bumped its version from 1.11.0 to 1.13.0 in ko-vendor. This fixes the following issue: #216
|
Build passing: https://github.com/ko4life-net/ko/actions/runs/8862455572/job/24335427956 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes spdlog build errors and resolves the following issue: #216
Related PR that needs to be merged first and create a new release before merging this one: ko4life-net/ko-vendor#11
I also enforced the config file to use that branch, so that versioning properly works and doesn't break when other repos gets updated.