Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(community): 공지사항 페이지 #37
feat(community): 공지사항 페이지 #37
Changes from 27 commits
a38282f
b4e3ee1
43ec47c
bc2200d
f1bb7c0
9f7467c
be38b71
d6fb7a4
a7568f6
6c6d5dd
b711674
2925d61
ddfe8b4
8097869
defb554
33342de
0fa8ab5
6b44468
af89e6a
cc32c1b
eeff403
d5976e7
36d84b7
f63df06
b8c505d
aca9b2d
092b8e3
7eb72ed
0e699c1
fbd5fe7
5bf115a
8565933
079cb3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 컴포넌트는 추상화 레벨, 결합도가 높다는 것이 걱정이네요. 현재 상태에서는 DS의 리스트에서 사용하기 어렵다고 판단되어 이와 같이 구현한 것으로 보여지는데요. 일단 넘어가고 나중에 DS 리스트를 활용하는 것이 좋아보여요.
다른 분들 좋은 아이디어가 있다면 피드백주세요