feat(community): 공지사항 페이지 #37
Merged
+1,136
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Copilot reviewed 6 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (9)
- packages/design-system/package.json: Language not supported
- apps/community/src/components/board/page-controller.tsx: Evaluated as low risk
- pnpm-lock.yaml: Evaluated as low risk
- apps/community/src/app/board/notice/page.tsx: Evaluated as low risk
- apps/community/src/constants/api.ts: Evaluated as low risk
- apps/community/src/components/board/list.tsx: Evaluated as low risk
- apps/community/src/components/board/search-bar.tsx: Evaluated as low risk
- packages/design-system/src/icons/lucide.ts: Evaluated as low risk
- apps/community/src/app/board/notice/remote.ts: Evaluated as low risk
gwansikk
requested changes
Nov 29, 2024
gwansikk
requested changes
Nov 29, 2024
|
|
||
| import * as styles from '~/components/board/board-list.css'; | ||
|
|
||
| async function BoardList({ data }: { data: Board[] }) { |
There was a problem hiding this comment.
해당 컴포넌트는 추상화 레벨, 결합도가 높다는 것이 걱정이네요. 현재 상태에서는 DS의 리스트에서 사용하기 어렵다고 판단되어 이와 같이 구현한 것으로 보여지는데요. 일단 넘어가고 나중에 DS 리스트를 활용하는 것이 좋아보여요.
다른 분들 좋은 아이디어가 있다면 피드백주세요
m2na7
reviewed
Dec 1, 2024
m2na7
approved these changes
Dec 2, 2024
gwansikk
approved these changes
Dec 2, 2024
apps/community/src/types/api.ts
Outdated
| @@ -1,5 +1,12 @@ | |||
| import type { Board, Pagable } from './board'; | |||
There was a problem hiding this comment.
Suggested change
| import type { Board, Pagable } from './board'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
공지사항 페이지 퍼블리싱을 하였어요.
Tasks
To Reviewer
디자인적으로 수정사항이 필요하거나 아이디어가 떠오른다면 적극적으로 말해주세요!
Screenshot
(기존 page의 size는 10이나, 촬영 편의성을 위해 5로 조정하였어요.)